Linux follow Steam icon standards, and retry different CDNs#6
Open
PseudoResonance wants to merge 1 commit intoayesc9000:masterfrom
Open
Linux follow Steam icon standards, and retry different CDNs#6PseudoResonance wants to merge 1 commit intoayesc9000:masterfrom
PseudoResonance wants to merge 1 commit intoayesc9000:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5 by properly implementing GTK icon standards and following the method that Steam uses on game install.
$HOME/.local/share/icons/hicolorto store icons in variable resolutions (ex: under16x16/apps,32x32/apps, and so on), otherwise store icon as simple PNG in supplied directory.Additionally, cycle through known CDN URLs instead of a single hard coded option for in case one is ever retired.
Edit: I also changed the "Shortcut doesn't appear to be a Steam shortcut" message to be blue, because previously, it would blend in with the "Icon missing, valid Steam game" message and made it a little more difficult to see which icons were really being detected as missing.